Skip to content

Commit

Permalink
Remove references to removed react-dom/server APIs in Webpack shims (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
eps1lon authored Aug 20, 2024
1 parent 9018131 commit bfa7df4
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 92 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ if (process.env.NODE_ENV === 'production') {
exports.version = l.version
exports.renderToString = l.renderToString
exports.renderToStaticMarkup = l.renderToStaticMarkup
exports.renderToNodeStream = l.renderToNodeStream
exports.renderToStaticNodeStream = l.renderToStaticNodeStream
exports.renderToReadableStream = s.renderToReadableStream
if (s.resume) {
exports.resume = s.resume
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ if (process.env.NODE_ENV === 'production') {
exports.version = l.version
exports.renderToString = l.renderToString
exports.renderToStaticMarkup = l.renderToStaticMarkup
exports.renderToNodeStream = l.renderToNodeStream
exports.renderToStaticNodeStream = l.renderToStaticNodeStream
exports.renderToReadableStream = s.renderToReadableStream
if (s.resume) {
exports.resume = s.resume
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ if (process.env.NODE_ENV === 'production') {

exports.version = b.version
exports.renderToReadableStream = b.renderToReadableStream
exports.renderToNodeStream = b.renderToNodeStream
exports.renderToStaticNodeStream = b.renderToStaticNodeStream
exports.renderToString = error
exports.renderToStaticMarkup = error
if (b.resume) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ if (process.env.NODE_ENV === 'production') {

exports.version = b.version
exports.renderToReadableStream = b.renderToReadableStream
exports.renderToNodeStream = b.renderToNodeStream
exports.renderToStaticNodeStream = b.renderToStaticNodeStream
exports.renderToString = error
exports.renderToStaticMarkup = error
if (b.resume) {
Expand Down
136 changes: 52 additions & 84 deletions test/development/app-dir/ssr-in-rsc/ssr-in-rsc.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,16 @@ describe('react-dom/server in React Server environment', () => {
.toMatchInlineSnapshot(`
"{
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
Expand All @@ -113,19 +109,15 @@ describe('react-dom/server in React Server environment', () => {
.toMatchInlineSnapshot(`
"{
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
]
Expand Down Expand Up @@ -208,20 +200,16 @@ describe('react-dom/server in React Server environment', () => {
.toMatchInlineSnapshot(`
"{
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
Expand All @@ -231,26 +219,22 @@ describe('react-dom/server in React Server environment', () => {
} else {
expect(await browser.elementByCss('main').text())
.toMatchInlineSnapshot(`
"{
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
]
}"
`)
"{
"default": [
"renderToReadableStream",
"renderToStaticMarkup",
"renderToString",
"version"
],
"named": [
"default",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToString",
"version"
]
}"
`)
}
}
const redbox = {
Expand Down Expand Up @@ -499,20 +483,16 @@ describe('react-dom/server in React Server environment', () => {
"{
"default": {
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
Expand All @@ -523,28 +503,24 @@ describe('react-dom/server in React Server environment', () => {
} else {
expect(await browser.elementByCss('main').text())
.toMatchInlineSnapshot(`
"{
"default": {
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
]
}
}"
`)
"{
"default": {
"default": [
"renderToReadableStream",
"renderToStaticMarkup",
"renderToString",
"version"
],
"named": [
"default",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToString",
"version"
]
}
}"
`)
}
}
const redbox = {
Expand Down Expand Up @@ -627,20 +603,16 @@ describe('react-dom/server in React Server environment', () => {
"{
"default": {
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"resume",
"version"
Expand All @@ -651,28 +623,24 @@ describe('react-dom/server in React Server environment', () => {
} else {
expect(await browser.elementByCss('main').text())
.toMatchInlineSnapshot(`
"{
"default": {
"default": [
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
],
"named": [
"default",
"renderToNodeStream",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToStaticNodeStream",
"renderToString",
"version"
]
}
}"
`)
"{
"default": {
"default": [
"renderToReadableStream",
"renderToStaticMarkup",
"renderToString",
"version"
],
"named": [
"default",
"renderToReadableStream",
"renderToStaticMarkup",
"renderToString",
"version"
]
}
}"
`)
}
}
const redbox = {
Expand Down

0 comments on commit bfa7df4

Please sign in to comment.