Skip to content

Commit

Permalink
chore(turbo-tasks-backend): Disable flaky performance test by default (
Browse files Browse the repository at this point in the history
…#70974)

The CI environment is **very** noisy and this test can (and does) flake:
#69667 (comment)

```
cargo nextest r -p turbo-tasks-memory many_calls_to_many_children --no-capture
```

```
TURBOPACK_TEST_PERFORMANCE=yes cargo nextest r -p turbo-tasks-memory many_calls_to_many_children --no-capture
```

The plan to solve this is to integrate codspeed, which should guarantee
low noise via an emulated CPU.
  • Loading branch information
bgw authored and kdy1 committed Oct 10, 2024
1 parent 881bd33 commit ad167c9
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions turbopack/crates/turbo-tasks-testing/tests/performance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ const COUNT2: u32 = 2000;

#[tokio::test]
async fn many_calls_to_many_children() {
if matches!(
std::env::var("TURBOPACK_TEST_PERFORMANCE").ok().as_deref(),
None | Some("") | Some("no") | Some("false")
) {
println!("Skipping test, pass `TURBOPACK_TEST_PERFORMANCE=yes` to run it");
return;
}

run(&REGISTRATION, || async {
// The first call will actually execute many_children and its children.
let start = std::time::Instant::now();
Expand Down

0 comments on commit ad167c9

Please sign in to comment.