Skip to content

Commit

Permalink
Make synced react-is version more obvious (#67189)
Browse files Browse the repository at this point in the history
  • Loading branch information
eps1lon authored Jun 26, 2024
1 parent d4e349f commit a832c91
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 12 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@
"react-dom-builtin": "npm:react-dom@19.0.0-rc-6230622a1a-20240610",
"react-dom-experimental-builtin": "npm:react-dom@0.0.0-experimental-6230622a1a-20240610",
"react-experimental-builtin": "npm:react@0.0.0-experimental-6230622a1a-20240610",
"react-is-builtin": "npm:react-is@19.0.0-rc-6230622a1a-20240610",
"react-server-dom-turbopack": "19.0.0-rc-6230622a1a-20240610",
"react-server-dom-turbopack-experimental": "npm:react-server-dom-turbopack@0.0.0-experimental-6230622a1a-20240610",
"react-server-dom-webpack": "19.0.0-rc-6230622a1a-20240610",
Expand Down
1 change: 0 additions & 1 deletion packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@
"punycode": "2.1.1",
"querystring-es3": "0.2.1",
"raw-body": "2.4.1",
"react-is": "19.0.0-rc-f994737d14-20240522",
"react-refresh": "0.12.0",
"regenerator-runtime": "0.13.4",
"sass-loader": "12.6.0",
Expand Down
15 changes: 7 additions & 8 deletions packages/next/taskfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -730,13 +730,6 @@ export async function ncc_buffer(task, opts) {
.target('src/compiled/buffer')
}

// eslint-disable-next-line camelcase
export async function copy_react_is(task, opts) {
await task
.source(join(dirname(require.resolve('react-is/package.json')), '**/*'))
.target('src/compiled/react-is')
}

// eslint-disable-next-line camelcase
export async function copy_constants_browserify(task, opts) {
await fs.mkdir(join(__dirname, 'src/compiled/constants-browserify'), {
Expand Down Expand Up @@ -1765,6 +1758,13 @@ export async function copy_vendor_react(task_) {
for (const res of copy_vendor_react_impl(task_, { experimental: true })) {
await res
}

// TODO: Support react-is experimental channel. We currently assume Canary and Experimental are equal.
await task_
.source(
join(dirname(require.resolve('react-is-builtin/package.json')), '**/*')
)
.target('src/compiled/react-is')
}

// eslint-disable-next-line camelcase
Expand Down Expand Up @@ -2307,7 +2307,6 @@ export async function ncc(task, opts) {
'copy_vercel_og',
'copy_constants_browserify',
'copy_vendor_react',
'copy_react_is',
'ncc_sass_loader',
'ncc_jest_worker',
'ncc_edge_runtime_cookies',
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a832c91

Please sign in to comment.