Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper implicitly using Notepad to edit preferences #5504

Open
2 tasks done
aaryanporwal opened this issue Apr 18, 2021 · 7 comments · May be fixed by #5505
Open
2 tasks done

Hyper implicitly using Notepad to edit preferences #5504

aaryanporwal opened this issue Apr 18, 2021 · 7 comments · May be fixed by #5505

Comments

@aaryanporwal
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name:
    OS Name: Microsoft Windows 10 Home Single Language
    OS Version: 10.0.19041 N/A Build 1904

  • Hyper.app version:
    3.0.2 (latest)

  • The issue is reproducible in vanilla Hyper.app:
    Is Vanilla

Issue

Hyper implicitly uses Notepad.exe to edit its preferences, but from Windows 2004 onwards, notepad has become an optional feature and doesn't come pre-installed. This leads to the following error:
image
image

@RealCyGuy
Copy link

RealCyGuy commented Apr 18, 2021

It's not implicit, it's used as a fallback.

const openNotepad = (file: string) =>
It uses notepad when there isn't a default app for .js files.

@RealCyGuy
Copy link

I think wordpad is still preinstalled, it can be a fallback for notepad.

@RealCyGuy RealCyGuy linked a pull request Apr 18, 2021 that will close this issue
@aaryanporwal
Copy link
Author

Yeah wordpad is a better fallback, thanks!

@Stanzilla
Copy link
Collaborator

Stanzilla commented May 16, 2021

If you don't have Notepad, that's a bug. Notepad is still installed by default on Windows 10.

https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/features-on-demand-non-language-fod

@aaryanporwal
Copy link
Author

It is under optional features:
image
https://answers.microsoft.com/en-us/windows/forum/windows_10-files/notepad-missing-in-windows-10-v2004/aefadf15-e830-4279-b9a3-591581ebb35a

@Stanzilla
Copy link
Collaborator

Yes but no Notepad being installed is a bug and not intended.

@karstengresch
Copy link

karstengresch commented Nov 28, 2022

No notepad installed can be a decision ;)

Thus, the error message should be changed to:

"
Cannot find the default editor for *.js files to open '.hyper.js'. Please make sure you have a default text editor set up to open *.js files.
"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants