Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Opacity on 2.0 does not work in the same way? #2827

Open
2 tasks done
iamthemovie opened this issue Apr 16, 2018 · 11 comments
Open
2 tasks done

Font Opacity on 2.0 does not work in the same way? #2827

iamthemovie opened this issue Apr 16, 2018 · 11 comments
Labels
⚡ Type: Regression This used to work before but a recent update broke it.

Comments

@iamthemovie
Copy link

iamthemovie commented Apr 16, 2018

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 x64 (Redstone 3)
  • Hyper.app version: 2.0
  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/iamthemovie/71c924d36400df5d582f93adbf87d104
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app: Using the hyper-material-box and hyperlinks.

Issue

Just updated to 2.0 and it looks like the font opacity is stuck. I was running the latest of 1.X hyper and this was working fine but literally just updated and my font is no longer the correct opacity. I realise this plugin maybe at fault but since it worked on 1.X and now has issues on 2.X I wondered if anyone could point in the direction where this problem might stem from?

1.0 (Nice and lovely)
image

2.0 (Still nice, not as easy to love)
image
image

Edit: The colours look darker between versions on this also #2821

@chabou
Copy link
Collaborator

chabou commented Apr 16, 2018

Yes default colors has been changed: #2670
We are now using iTerm2 defautls and it permits usage of bright colors.

You can restore previous color scheme by setting in your config, old color scheme:

    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
  }

@Astrophizz
Copy link

Even themes look dimmer than they did in 1.x. It's not just a matter of the default color scheme changing.

@iamthemovie
Copy link
Author

iamthemovie commented Apr 17, 2018 via email

@mashaal
Copy link

mashaal commented Apr 18, 2018

I am experiencing the same issue -- it seems the culprit is a line of css is setting my active window to .5 opacity. I've disabled all of my plugins and issue still persists.

#hyper .term_fit:not(.term_term) {
  opacity: .5
}

hyper

@mashaal
Copy link

mashaal commented Apr 18, 2018

Not great, but this will fix it for the time being.

In the config css...

// custom css to embed in the main window
    css: `
      .term_fit:not(.term_term) {
        opacity: 1 !important
      }
    `,

@iamthemovie
Copy link
Author

@mashaal does this that take into account active pane? For instance if you split then before 2.0 the opacity would be 0.6 on the non-active window (which is super useful). I know it's a temporary fix, I'm just putting this comment for the guys at zeit's benefit 😄

@mashaal
Copy link

mashaal commented Apr 18, 2018

@iamthemovie i saw on a higher up node there was an active class with an opacity set -- not totally sure what the term_fit opacity is meant to be controlling. I feel like this may be an issue with conflicting css -- please see gif below -- in the inspector it shows the css line being overridden, but the .5 opacity is still being rendered regardless?

hyper-conflict

@Stanzilla Stanzilla added the ⚡ Type: Regression This used to work before but a recent update broke it. label Apr 23, 2018
@danielcorin
Copy link

danielcorin commented Apr 24, 2018

Admittedly a hacky fix as I haven't done my due diligence on the use of these class selectors in the css but the following works for me on macOS, Hyper 2.0.0 (stable):

css: `
  .terminal:not(.focus) {
    opacity: 0.6;
  }
  .terminal.focus {
    opacity: 1;
  }`,

@pvorona
Copy link

pvorona commented Apr 26, 2018

For some reason in my hyper this css is in style tag (I've changed 0.6 to 1 but still WTF? why is it here?):
screen shot 2018-04-26 at 21 51 37

@chabou
Copy link
Collaborator

chabou commented Apr 26, 2018

I added inactive pane dimming in hyper-pane plugin recently.
CSS class selection should be done carefully. Please see:
chabou/hyper-pane@75aba86

@ahmadawais
Copy link

I'm using this to debug this issue.

// Custom css to embed in the main window.
    css: `
      .term_fit:not(.term_term) {
        opacity: 1 !important
      }
      .terminal: not(.focus) {
        opacity: 1;
        }
      .terminal.focus {
        opacity: 1;
      }
    `,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Regression This used to work before but a recent update broke it.
Projects
None yet
Development

No branches or pull requests

8 participants