test(e2e): cover authorized approval responses - #1824
Open
benpankow wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
benpankow
force-pushed
the
ben/hitl-v2-docs-contracts
branch
from
August 7, 2026 23:14
b81b7f4 to
ea75d7c
Compare
benpankow
force-pushed
the
ben/hitl-v2-authorized-response-e2e
branch
from
August 7, 2026 23:14
11e3bca to
f5fb14d
Compare
| const parked = await t.send(`Call the \`${TOOL_NAME}\` tool with marker "${MARKER}".`); | ||
| const approval = t.requireInputRequest({ display: "confirmation", toolName: TOOL_NAME }); | ||
| parked.calledTool(TOOL_NAME, { status: "pending", count: 1 }); | ||
|
|
Contributor
| afterApproval.event("authorization.required", { count: 1 }); | ||
|
|
||
| const startIndex = t.events.length; | ||
| const callback = await t.target.fetch(required.data.authorization.url); |
Contributor
benpankow
force-pushed
the
ben/hitl-v2-docs-contracts
branch
from
August 7, 2026 23:20
ea75d7c to
64d990f
Compare
benpankow
force-pushed
the
ben/hitl-v2-authorized-response-e2e
branch
from
August 7, 2026 23:20
f5fb14d to
a87306e
Compare
De-ASI-INTERFACE
approved these changes
Aug 7, 2026
De-ASI-INTERFACE
approved these changes
Aug 7, 2026
benpankow
force-pushed
the
ben/hitl-v2-docs-contracts
branch
from
August 7, 2026 23:49
64d990f to
4993498
Compare
benpankow
force-pushed
the
ben/hitl-v2-authorized-response-e2e
branch
from
August 7, 2026 23:49
a87306e to
6a88d1b
Compare
benpankow
force-pushed
the
ben/hitl-v2-docs-contracts
branch
from
August 7, 2026 23:53
4993498 to
1aecc5f
Compare
benpankow
force-pushed
the
ben/hitl-v2-authorized-response-e2e
branch
from
August 7, 2026 23:54
6a88d1b to
b4e9924
Compare
benpankow
force-pushed
the
ben/hitl-v2-docs-contracts
branch
from
August 8, 2026 01:01
1aecc5f to
40f7697
Compare
benpankow
force-pushed
the
ben/hitl-v2-authorized-response-e2e
branch
from
August 8, 2026 01:01
b4e9924 to
92de737
Compare
Signed-off-by: benpankow <ben.pankow@vercel.com>
benpankow
force-pushed
the
ben/hitl-v2-docs-contracts
branch
from
August 8, 2026 01:15
40f7697 to
7c3c57c
Compare
benpankow
force-pushed
the
ben/hitl-v2-authorized-response-e2e
branch
from
August 8, 2026 01:15
92de737 to
25f3f9d
Compare
AndrewBarba
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds fixture-owned e2e coverage for the responder-authorized HITL lifecycle introduced by this stack.
The deterministic fixture authenticates the eval driver as a fixed user and defines a tool with explicit request and response policies:
The eval asserts:
It uses no external OAuth provider or injected credential, so the result is deterministic and self-contained.
This also adds compiler/runtime normalization coverage for the explicit
{ request, response }approval object; previously only the function shorthand was accepted by runtime normalization even though the public type allowed the object form.Depends on #1374.
Validation
pnpm --filter agent-tools-hitl typecheckpnpm --filter eve typecheckpnpm guard:invariants