chore: migrate to getSetCookie

packages/integration-tests/tests/response.test.ts

@@ -10,6 +10,9 @@ test('allow to append multiple `set-cookie` header', async () => {
   const response = new Response(null)
   response.headers.append('set-cookie', 'foo=bar')
   response.headers.append('set-cookie', 'bar=baz')
+
+  expect(response.headers.getSetCookie()).toEqual(['foo=bar', 'bar=baz'])
+
   expect(response.headers.getAll?.('set-cookie')).toEqual([
     'foo=bar',
     'bar=baz',

packages/node-utils/src/edge-to-node/handler.ts

@@ -12,20 +12,20 @@ import { toToReadable } from './stream'
 
 export function buildToNodeHandler(
   dependencies: BuildDependencies,
-  options: RequestOptions
+  options: RequestOptions,
 ) {
   const toRequest = buildToRequest(dependencies)
   const toFetchEvent = buildToFetchEvent(dependencies)
   return function toNodeHandler(webHandler: WebHandler): NodeHandler {
     return (
       incomingMessage: IncomingMessage,
-      serverResponse: ServerResponse
+      serverResponse: ServerResponse,
     ) => {
       const request = toRequest(incomingMessage, options)
       const maybePromise = webHandler(request, toFetchEvent(request))
       if (maybePromise instanceof Promise) {
         maybePromise.then((response) =>
-          toServerResponse(response, serverResponse)
+          toServerResponse(response, serverResponse),
         )
       } else {
         toServerResponse(maybePromise, serverResponse)
@@ -36,16 +36,15 @@ export function buildToNodeHandler(
 
 function toServerResponse(
   webResponse: Response | null | undefined,
-  serverResponse: ServerResponse
+  serverResponse: ServerResponse,
 ) {
   if (!webResponse) {
     serverResponse.end()
     return
   }
   mergeIntoServerResponse(
-    // @ts-ignore getAll() is not standard https://fetch.spec.whatwg.org/#headers-class
     toOutgoingHeaders(webResponse.headers),
-    serverResponse
+    serverResponse,
   )
 
   serverResponse.statusCode = webResponse.status

packages/node-utils/src/edge-to-node/headers.ts

@@ -13,7 +13,9 @@ export function toOutgoingHeaders(
       outputHeaders[name] = value
       if (name.toLowerCase() === 'set-cookie') {
         outputHeaders[name] =
-          headers.getAll?.('set-cookie') ?? splitCookiesString(value)
+          headers.getSetCookie?.() ??
+          headers.getAll?.('set-cookie') ??
+          splitCookiesString(value)
       }
     }
   }

packages/node-utils/test/edge-to-node/headers.test.ts

@@ -7,8 +7,8 @@ it('handles simple header values', () => {
       new Headers({
         'Content-Type': 'image/jpeg',
         'X-My-Custom-Header': 'Zeke are cool',
-      })
-    )
+      }),
+    ),
   ).toEqual({
     'content-type': 'image/jpeg',
     'x-my-custom-header': 'Zeke are cool',
@@ -24,7 +24,7 @@ it('splits set-cookie with getAll()', () => {
   })
 })
 
-it('slits set-cookie without getAll()', () => {
+it('splits set-cookie without getAll()', () => {
   const rawHeaders = {
     raw: () => ({
       'set-cookie':

packages/primitives/src/primitives/fetch.js

@@ -49,6 +49,7 @@ HeadersModule.Headers.prototype.values = function* () {
  * Add a new method for retrieving all independent `set-cookie` headers that
  * maybe have been appended. This will only work when getting `set-cookie`
  * headers.
+ * @deprecated use [`Headers#getSetCookie()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie) instead
  */
 HeadersModule.Headers.prototype.getAll = function (name) {
   const _name = normalizeAndValidateHeaderName(name, 'Headers.getAll')

packages/primitives/type-definitions/fetch.d.ts

@@ -1,4 +1,5 @@
 export class Headers extends globalThis.Headers {
+  /** @deprecated use [`Headers#getSetCookie()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie) instead */
   getAll?(key: 'set-cookie'): string[]
 }
 
@@ -16,7 +17,7 @@ export type RequestInfo = string | Request | globalThis.Request
 export type RequestInit = globalThis.RequestInit
 declare const fetchImplementation: (
   info: RequestInfo,
-  init?: RequestInit
+  init?: RequestInit,
 ) => Promise<Response>
 
 declare const FileConstructor: typeof File

packages/runtime/src/server/create-handler.ts

@@ -39,7 +39,7 @@ export function createHandler<T extends EdgeContext>(options: Options<T>) {
             ? getClonableBodyStream(
                 req,
                 options.runtime.evaluate('Uint8Array'),
-                options.runtime.context.TransformStream
+                options.runtime.context.TransformStream,
               )
             : undefined
 
@@ -49,7 +49,7 @@ export function createHandler<T extends EdgeContext>(options: Options<T>) {
             headers: toRequestInitHeaders(req),
             method: req.method,
             body: body?.cloneBodyStream(),
-          }
+          },
         )
 
         const waitUntil = response.waitUntil()
@@ -60,7 +60,7 @@ export function createHandler<T extends EdgeContext>(options: Options<T>) {
         res.statusMessage = response.statusText
 
         for (const [key, value] of Object.entries(
-          toNodeHeaders(response.headers)
+          toNodeHeaders(response.headers),
         )) {
           if (value !== undefined) {
             res.setHeader(key, value)
@@ -112,18 +112,14 @@ function toRequestInitHeaders(req: IncomingMessage): RequestInit['headers'] {
 
 /**
  * Transforms WHATWG Headers into a Node Headers shape. Copies all items but
- * does a special case for Set-Cookie using the hidden method getAll which
- * allows to get all cookies instead of a folded value.
+ * does a special case for Set-Cookie using the [`getSetCookie`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie) method.
  */
 function toNodeHeaders(headers?: Headers): NodeHeaders {
   const result: NodeHeaders = {}
   if (headers) {
     for (const [key, value] of headers.entries()) {
       result[key] =
-        key.toLowerCase() === 'set-cookie'
-          ? // @ts-ignore getAll is hidden in Headers but exists.
-            headers.getAll('set-cookie')
-          : value
+        key.toLowerCase() === 'set-cookie' ? headers.getSetCookie() : value
     }
   }
   return result