Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form submissions, update packages. #1209

Merged
merged 16 commits into from
Oct 11, 2023
Prev Previous commit
Next Next commit
Prevent double clicks
  • Loading branch information
leerob committed Oct 1, 2023
commit 9ef95719a4649b7dbb485d2e28f1c820fcdec2bc
2 changes: 1 addition & 1 deletion components/cart/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { addToCart, createCart, getCart, removeFromCart, updateCart } from 'lib/
import { revalidateTag } from 'next/cache';
import { cookies } from 'next/headers';

export async function addItem(prevState: any, selectedVariantId: string) {
export async function addItem(prevState: any, selectedVariantId: string | undefined) {
let cartId = cookies().get('cartId')?.value;
let cart;

Expand Down
27 changes: 23 additions & 4 deletions components/cart/add-to-cart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { addItem } from 'components/cart/actions';
import LoadingDots from 'components/loading-dots';
import { ProductVariant } from 'lib/shopify/types';
import { useSearchParams } from 'next/navigation';
import { useState } from 'react';
import {
// @ts-ignore
experimental_useFormState as useFormState,
Expand All @@ -14,12 +15,15 @@ import {

function SubmitButton({
availableForSale,
selectedVariantId
selectedVariantId,
submitting
}: {
availableForSale: boolean;
selectedVariantId: string | undefined;
submitting: boolean;
}) {
const { pending } = useFormStatus();
let { pending } = useFormStatus();
pending = pending || submitting;
const buttonClasses =
'relative flex w-full items-center justify-center rounded-full bg-blue-600 p-4 tracking-wide text-white';
const disabledClasses = 'cursor-not-allowed opacity-60 hover:opacity-60';
Expand Down Expand Up @@ -72,6 +76,7 @@ export function AddToCart({
variants: ProductVariant[];
availableForSale: boolean;
}) {
const [submitting, setSubmitting] = useState(false);
const [message, formAction] = useFormState(addItem, null);
const searchParams = useSearchParams();
const defaultVariantId = variants.length === 1 ? variants[0]?.id : undefined;
Expand All @@ -84,8 +89,22 @@ export function AddToCart({
const actionWithVariant = formAction.bind(null, selectedVariantId);

return (
<form action={actionWithVariant}>
<SubmitButton availableForSale={availableForSale} selectedVariantId={selectedVariantId} />
<form
action={actionWithVariant}
// Prevent double clicks
onClick={async (e) => {
e.preventDefault();
if (submitting) return;
setSubmitting(true);
await addItem(message, selectedVariantId);
setSubmitting(false);
}}
>
<SubmitButton
availableForSale={availableForSale}
selectedVariantId={selectedVariantId}
submitting={submitting}
/>
<p aria-live="polite" className="sr-only" role="status">
{message}
</p>
Expand Down
21 changes: 17 additions & 4 deletions components/cart/delete-item-button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ import clsx from 'clsx';
import { removeItem } from 'components/cart/actions';
import LoadingDots from 'components/loading-dots';
import type { CartItem } from 'lib/shopify/types';
import { useState } from 'react';
import {
// @ts-ignore
experimental_useFormState as useFormState,
experimental_useFormStatus as useFormStatus
} from 'react-dom';

function SubmitButton() {
const { pending } = useFormStatus();
function SubmitButton({ submitting }: { submitting: boolean }) {
let { pending } = useFormStatus();
pending = pending || submitting;

return (
<button
Expand All @@ -36,13 +38,24 @@ function SubmitButton() {
}

export function DeleteItemButton({ item }: { item: CartItem }) {
const [submitting, setSubmitting] = useState(false);
const [message, formAction] = useFormState(removeItem, null);
const itemId = item.id;
const actionWithVariant = formAction.bind(null, itemId);

return (
<form action={actionWithVariant}>
<SubmitButton />
<form
action={actionWithVariant}
// Prevent double clicks
onClick={async (e) => {
e.preventDefault();
if (submitting) return;
setSubmitting(true);
await removeItem(message, itemId);
setSubmitting(false);
}}
>
<SubmitButton submitting={submitting} />
<p aria-live="polite" className="sr-only" role="status">
{message}
</p>
Expand Down
21 changes: 17 additions & 4 deletions components/cart/edit-item-quantity-button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ import clsx from 'clsx';
import { updateItemQuantity } from 'components/cart/actions';
import LoadingDots from 'components/loading-dots';
import type { CartItem } from 'lib/shopify/types';
import { useState } from 'react';
import {
// @ts-ignore
experimental_useFormState as useFormState,
experimental_useFormStatus as useFormStatus
} from 'react-dom';

function SubmitButton({ type }: { type: 'plus' | 'minus' }) {
const { pending } = useFormStatus();
function SubmitButton({ type, submitting }: { type: 'plus' | 'minus'; submitting: boolean }) {
let { pending } = useFormStatus();
pending = pending || submitting;

return (
<button
Expand All @@ -39,6 +41,7 @@ function SubmitButton({ type }: { type: 'plus' | 'minus' }) {
}

export function EditItemQuantityButton({ item, type }: { item: CartItem; type: 'plus' | 'minus' }) {
const [submitting, setSubmitting] = useState(false);
const [message, formAction] = useFormState(updateItemQuantity, null);
const payload = {
lineId: item.id,
Expand All @@ -48,8 +51,18 @@ export function EditItemQuantityButton({ item, type }: { item: CartItem; type: '
const actionWithVariant = formAction.bind(null, payload);

return (
<form action={actionWithVariant}>
<SubmitButton type={type} />
<form
action={actionWithVariant}
// Prevent double clicks
onClick={async (e) => {
e.preventDefault();
if (submitting) return;
setSubmitting(true);
await updateItemQuantity(message, payload);
setSubmitting(false);
}}
>
<SubmitButton type={type} submitting={submitting} />
<p aria-live="polite" className="sr-only" role="status">
{message}
</p>
Expand Down