Adds environment variable validation #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
|
i've also seen multiple matters of confusion around these Shopify variables — including my own — and upon requesting clarification the responses have been very dismissive — including to my own. it's clearly a point of confusion for many so perhaps the relevant docs aren't quite clear enough and/or could be better |
|
@fucha-co happy to make changes! Can you explain what is unclear? Do you have suggestions on what changes should be made? |
leerob
approved these changes
Oct 2, 2023
bc-alexsaiannyi
pushed a commit
to bigcommerce/nextjs-commerce
that referenced
this pull request
Dec 7, 2023
* Adds environment variable validation * Adds bracket checking in SHOPIFY_STORE_DOMAIN * Prettier * Adds link --------- Co-authored-by: Lee Robinson <lrobinson2011@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get 1 -3 issues or comments a week about build errors (see #1189 and #1197, for example), which are due to missing environment variables.
This PR add some validation during the build process to ensure absolutely required env vars are present and throws a clearer error message.