Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydration error #1117

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Fix hydration error #1117

merged 6 commits into from
Jul 28, 2023

Conversation

leerob
Copy link
Member

@leerob leerob commented Jul 25, 2023

We implemented #1115, which introduces an infinite refresh loop when visiting the product detail page. #1116 was then created to revert #1115.

This implementation simplifies the implementation (somewhat) and it no longer requires router or redirect to work.

This change will also accommodate additional state (like #1105) or even "bad" state (like color=ASDF).

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 10:00pm

@manovotny manovotny marked this pull request as ready for review July 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants