feat: next/remix/react supports updating beforeSend #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
force-pushed
the
damien/log-900-make-beforesend-changeable
branch
from
285283d
to
45f084b
Compare
feugy
force-pushed
the
damien/log-900-make-beforesend-changeable
branch
from
45f084b
to
bb0aa90
Compare
Base automatically changed from
damien/log-827-deploy-route-support-for-other-framework
to
main
November 7, 2024 13:17
feugy
force-pushed
the
damien/log-900-make-beforesend-changeable
branch
from
e6d3d7a
to
9f25f05
Compare
tobiaslins
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
Supports updating
beforeSendin next/react/remix components.🤺 How to test?
I made some unit tests for this.
🔬Notes to reviewers
We don't think it worth supporting this with astro/sveltekit/vue/nuxt. Let's wait for use cases first.
I've used describe.each to simplify our unit tests and avoid duplication.