Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 support #149

Merged
merged 4 commits into from
Oct 25, 2024
Merged

React 19 support #149

merged 4 commits into from
Oct 25, 2024

Conversation

tobiaslins
Copy link
Collaborator

@tobiaslins tobiaslins commented Oct 23, 2024

Allow react 19 rc as peer dependency

@tobiaslins tobiaslins requested a review from feugy October 23, 2024 09:56
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:03am
analytics-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:03am

Copy link

socket-security bot commented Oct 23, 2024

Copy link

socket-security bot commented Oct 23, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/types-react-dom@19.0.0-rc.1 ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/types-react-dom@19.0.0-rc.1

@tobiaslins
Copy link
Collaborator Author

Fix #148

Copy link
Member

@feugy feugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

Successfully tested locally.

@feugy feugy merged commit 524af71 into main Oct 25, 2024
8 checks passed
@feugy feugy deleted the next-15-support branch October 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants