-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(provider/xai): correct usage token calculation for reasoning models #12425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+244
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrammel
approved these changes
Feb 11, 2026
Collaborator
Author
Collaborator
Author
|
also @williamlmao i know you reported the original issue so tagging you in would love some community feedback once this is merged! pls! |
Contributor
|
Will take a look in few hours, thanks for working on this |
Contributor
|
Just confirmed this with the team, will add it to docs on our side as well. Thank you! Good to merge |
shaper
approved these changes
Feb 11, 2026
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
follow-up to #11536 — xAI's API reports
completion_tokensas text-only, withreasoning_tokensseparate incompletion_tokens_details(unlike OpenAI which includes reasoning incompletion_tokens). per xAI docs: "reasoning token consumption will be counted separately from completion_tokens, but will be counted in the total_tokens"this results in negative
textTokensand underreportedoutputTokensfor all reasoning models (grok-4, grok-3-mini, grok-3-mini-fast, grok-code-fast-1, etc.)summary
outputTokens.totalfromcompletion_tokenstocompletion_tokens + reasoningTokensoutputTokens.textfromcompletion_tokens - reasoningTokenstocompletion_tokensverification
before (negative tokens)
after (correct)
checklist
pnpm changesetin root)