fix(ui): use local activeResponse in finally block to prevent TypeError #12344
+37
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where
this.activeResponsecould be undefined in the finally block ofmakeRequest, causing a TypeError when callingonFinish.Problem
The issue occurred when:
this.activeResponsewas assignedmakeRequestcall overwrotethis.activeResponseThis caused:
Solution
The fix uses a local variable to capture
activeResponseat the start of the try block:let activeResponsebefore the try blockThis ensures the reference is stable and available even if
this.activeResponseis modified by concurrent operations.Credit
Thanks to @codybrouwers for identifying the root cause and providing the patch in the issue comments.
Fixes #8477