fix: memo comparison functions return false instead of true #1329
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose a fix for
React.memocomparison functions inMessagesandPreviewMessagethat always returnefalse, effectively disabling memoization.Problem
Both components define a custom comparison function for
React.memo, but they end with an unconditionalreturn false.Because the final line is always
false, these components re-render on every parent update, regardless of whether the relevant props actually changed.Testing
Verified the app still updates when:
streaming→ready).Confirmed that, when props are unchanged, the components are now eligible to be skipped by
React.memo, reducing unnecessary re-renders in longer chats.