fix: PromptInputTextarea now actually handles its own damn resize logic
#1321
+103
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component was accepting
minHeight/maxHeight/disableAutoResizeprops and doing absolutely nothing with them. Meanwhile, the parent Composer/MultimodalInput hadadjustHeight()andresetHeight()functions that both just hardcoded"44px"and called it a day 🥂.What's fixed:
PromptInputTextareaChanges in MultimodalInput:
adjustHeight()andresetHeight()functionsref.current.style.heightmanipulationChanges in
PromptInputTextarea:forwardRefsupportuseEffectminHeight/maxHeightvia inline stylesresizeOnNewLinesOnlyoptimizationThe textarea now grows and shrinks nicely.
This PR will be followed by a fix (New PR) addressing the
scroll-to-bottombutton that currently doesn't respond to the auto-resizing text area input.Edit:
See #1322 for supplementary fixes