Fix Windows zero-native init path resolution error#55
Open
edengilbertus wants to merge 1 commit into
Open
Conversation
|
@edengilbertus is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Cause:
zero-nativeinitialization tries to locate its source files by taking its executable path (an absolute path) and joining it withsrc/root.zig. It passed this tostd.Io.Dir.cwd().openFile(). On macOS and Linux, the underlying POSIXopenatallows absolute paths, ignoring the directory file descriptor. However, on Windows,NtCreateFilerejects an absolute path when a parent directory handle (RootDirectory) is provided, causingcwd().openFileto throw an error. This causedhasFrameworkRootto silently catch the error and returnfalseon Windows.Fix:
Explicitly use
std.Io.Dir.openFileAbsoluteifstd.fs.path.isAbsolute(root_zig)is true, bypassing the directory handle and ensuring the absolute path is correctly read on Windows.