fix: strip UNC prefix from path on Windows to fix daemon startup #332
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, canonicalize() returns UNC path format (\?\C:\Users\...). When the CLI passes this path to Node.js to start the daemon, Node.js cannot correctly handle the UNC path format, causing "Daemon failed to start" error. This fix strips the UNC prefix before passing the path.
Contributor
|
@coofly is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix daemon startup failure on Windows when installed globally via npm.
Problem
On Windows,
canonicalize()returns UNC path format (\?\C:\Users\...). When the CLI passes this path to Node.js to start the daemon, Node.js cannot correctly handle the UNC path format, causing "Daemon failed to start" error.Solution
Strip the UNC prefix (
\?\) on Windows before passing the path to Node.js.Testing
cargo buildpassescargo testpasses (148 tests)