fix: add retry logic for transient socket errors #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes race condition when rapidly closing and opening browser sessions. The daemon has a 100ms shutdown delay, which caused the CLI to detect stale daemons as "running" and fail with EAGAIN errors. Changes: - Add retry logic (5 attempts, exponential backoff) for transient errors including EAGAIN, EOF, connection reset, and connection refused - Add 150ms verification delay in ensure_daemon to detect shutting-down daemons - Add cleanup_stale_files to remove leftover socket/PID files before starting a new daemon Tested with 20 rapid close/open cycles and 100+ parallel commands.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Extracts is_transient_error() function and adds 14 unit tests covering: - EAGAIN errors (macOS os error 35, Linux os error 11) - WouldBlock and Resource temporarily unavailable - EOF and empty JSON response errors - Connection reset (macOS os error 54, Linux os error 104) - Broken pipe errors - Socket not found (os error 2) - Connection refused (macOS os error 61, Linux os error 111) - Non-transient errors (verifies they are NOT retried)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes race condition when rapidly closing and opening browser sessions that caused
EAGAINerrors (os error 35 on macOS).ensure_daemonto detect shutting-down daemonscleanup_stale_filesto remove leftover socket/PID files before starting a new daemonTest plan