fix: exercise color helper tests #317
Open
+69
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure color tests call the real formatting helpers so they actually validate the NO_COLOR behavior instead of only checking format! output.
Contributor
|
@AdAstraAbyssoque is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the tests in cli/src/color.rs to actually call the red() and green() color helper functions instead of just testing format! output. The original tests never validated the actual logic that respects the NO_COLOR environment variable.
Changes:
- Updated
test_red_contains_ansi_codesto callred()and check output based onis_enabled() - Updated
test_green_contains_ansi_codesto callgreen()and validate actual output - No production code changes, only test improvements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
According to the suggestions from @copilot , we make updates to avoid NO_COLOR caching during tests and add env-guarded |
Avoid NO_COLOR caching during tests and add env-guarded coverage for both colored and non-colored paths.
AdAstraAbyssoque
force-pushed
the
fix-color-tests
branch
from
514370d to
5532380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the tests in
cli/src/color.rs. The original tests never called the real color helpers, so they only validatedformat!output rather than the actual logic. The updated tests now exercisered()/green()and assert behavior based onNO_COLOR.Why this change
Previously, the tests did:
format!("\x1b[31m{}...", "error")red()/green()As a result:
NO_COLOR) was never validatedWhat changed
test_red_contains_ansi_codesnow callsred(text)and checks ANSI prefix/reset when enabled, or plain text when disabledtest_green_contains_ansi_codesnow callsgreen(text)and validates actual outputTest plan
cargo test color --manifest-path cli/Cargo.toml