fix: allow delayed auto-connect DevTools handshake#1368
Open
SUSINDRAREDDY wants to merge 1 commit into
Open
Conversation
Contributor
|
@SUSINDRAREDDY is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Extends the WebSocket verification timeout used by --auto-connect from 2 seconds to 30 seconds so users have enough time to approve Chrome's remote-debugging permission prompt (#1365).
Changes:
- Introduce
AUTO_CONNECT_WS_VERIFY_TIMEOUTconstant (30s) and pass it through toverify_ws_endpoint. - Make
verify_ws_endpointaccept the timeout as a parameter instead of a hardcoded 2s value. - Add a regression test simulating a delayed (~2.2s) handshake.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--auto-connectFixes #1365.
Verification
cargo test --manifest-path cli/Cargo.toml native::cdp::chrome::tests::cargo fmt --manifest-path cli/Cargo.toml -- --checkcargo clippy --manifest-path cli/Cargo.toml --all-targets -- -D warningsgit diff --check