Skip to content

Conversation

@Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Sep 8, 2023

The request instance service_fn received is created by vercel runtime and has nothing in its extensions field. RequestExt will not work as expected.

dglsparsons
dglsparsons previously approved these changes Sep 11, 2023
@ecklf
Copy link
Collaborator

ecklf commented Sep 13, 2023

Currently we export this trait so we can access the payload on the request type. I think we could change this to just use RequestPayloadExt?

@Zxilly
Copy link
Contributor Author

Zxilly commented Sep 13, 2023

RequestPayloadExt didn't exist in lambda_http 0.7, we need to bump to a newer version.

@dglsparsons dglsparsons self-requested a review September 13, 2023 09:57
@dglsparsons dglsparsons dismissed their stale review September 13, 2023 09:58

no longer relevant

Copy link
Collaborator

@ecklf ecklf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ecklf ecklf merged commit 53d040c into vercel-community:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants