Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uuid.UUID as base for NewTagID() #30

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add uuid.UUID as base for NewTagID() #30

merged 2 commits into from
Jun 21, 2022

Conversation

CodingVoid
Copy link
Contributor

I stumbled upon it, while trying to generate a uuid and assign to SoftwareIdentity.TagID.
Now I can easily write for example:

var id swid.SoftwareIdentity
id.TagID = *swid.NewTagID(uuid.NewSHA1(uuid.NameSpaceDNS, "test"))

otherwise it get's complicated, since I can't access TagID's variable and there are no setter/getter like functions to get around it.

@CodingVoid
Copy link
Contributor Author

the github action for the linter doesn't seem to work anymore: "/home/runner/go/bin/golangci-lint: No such file or directory" @thomas-fossati

@thomas-fossati
Copy link
Contributor

@CodingVoid: Awesome, thanks!

I'll have a look at the linter problem ASAP.

@thomas-fossati
Copy link
Contributor

thomas-fossati commented Jun 21, 2022

hi @CodingVoid the CI problem is fixed in 7a698fd

Synchronising your fork and rebasing should clear the linters failure. NOTE: actually this is not needed: GitHub provides a handy button for that which I already pushed :-)

One last thing: could you also update the function comment to reflect the new accepted type?

Signed-off-by: CodingVoid <code.ivng5@simplelogin.co>
@CodingVoid
Copy link
Contributor Author

done

@thomas-fossati
Copy link
Contributor

done

Thanks!

tagid.go Outdated Show resolved Hide resolved
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CodingVoid

@thomas-fossati thomas-fossati merged commit 6261c52 into veraison:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants