Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hash-entry implementation #21

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Improve hash-entry implementation #21

merged 2 commits into from
Sep 7, 2021

Conversation

thomas-fossati
Copy link
Contributor

  1. make the algorithm identifiers visible to dependent packages
  2. check compatibility of algID and hashValue on Set so that we cannot
    end up in an unwanted state

Fixes #20

Also, improve coverage - therefore partially addressing #12.

@thomas-fossati thomas-fossati self-assigned this Sep 7, 2021
@thomas-fossati
Improve hash-entry implementation
66b8f00 
1. make the algorithm identifiers visible to dependent packages
2. check compatibility of algID and hashValue on Set so that we cannot
   end up in an unwanted state

Fixes #20

Also, improve coverage - therefore partially addressing #12.
@thomas-fossati thomas-fossati merged commit 8bbb616 into main Sep 7, 2021
@thomas-fossati thomas-fossati deleted the better-hash-entry branch September 7, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

@setrofim setrofim Awaiting requested review from setrofim

Assignees

@thomas-fossati thomas-fossati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: improve hash-entry
2 participants
@thomas-fossati @yogeshbdeshpande