Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo UnataggedSign1Message -> UntaggedSign1Message #148

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

spennymac
Copy link
Contributor

Small change to fix the typo.

@spennymac
Copy link
Contributor Author

Issue: #149

Copy link
Contributor

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #148 (e4012fa) into main (354ac99) will decrease coverage by 1.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   92.76%   90.87%   -1.90%     
==========================================
  Files          10       12       +2     
  Lines        1065     1611     +546     
==========================================
+ Hits          988     1464     +476     
- Misses         51      109      +58     
- Partials       26       38      +12     
Impacted Files Coverage Δ
sign1.go 90.10% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spennymac
Copy link
Contributor Author

Need one more reviewer :)

@spennymac spennymac force-pushed the smccreary/typo-fix branch from f75d29c to c39337e Compare June 30, 2023 17:01
Signed-off-by: Spencer McCreary <smccreary@squareup.com>
@spennymac spennymac force-pushed the smccreary/typo-fix branch from c39337e to e4012fa Compare June 30, 2023 17:05
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for spotting this

@yogeshbdeshpande yogeshbdeshpande merged commit 8ba8d69 into veraison:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants