Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no filename and filepath in results.json #40

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vincent-deng
Copy link
Collaborator

When analysing languages without debug symbols (e.g., dotnet), the Veracode policy findings API does not return filepath and filename information in the findings_details section. This causes the current action to fail because it relies on this information to convert results to sarif.

Solution:

Filtering: The pull request adds logic to filter out policy findings that lack filepath and filename information. This ensures that the action only processes findings that can be accurately reported.

Warning Annotation: A warning annotation has been added to alert users about the potential limitation. This provides a clear indication that findings for languages without debug symbols might have incomplete reporting.

Copy link
Contributor

@shailesh-veracode shailesh-veracode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants