Unlock/ignore dev ruby version & update CI ruby version #96
Conversation
* Remove .ruby-version and test against active Ruby versions * Ruby 2.1.2 is EOL, so that has been removed. * Loosen gem dependencies to keep project from getting stale * Update travis.yml to run a matrix build
deprecation message:
```
DEPRECATION WARNING: Leaving `ActiveRecord::ConnectionAdapters::SQLite3Adapter.represent_boolean_as_integer`
set to false is deprecated. SQLite databases have used 't' and 'f' to serialize
boolean values and must have old data converted to 1 and 0 (its native boolean
serialization) before setting this flag to true. Conversion can be accomplished
by setting up a rake task which runs
ExampleModel.where("boolean_column = 't'").update_all(boolean_column: 1)
ExampleModel.where("boolean_column = 'f'").update_all(boolean_column: 0)
for all models and all boolean columns, after which the flag must be set to
true by adding the following to your application.rb file:
Rails.application.config.active_record.sqlite3.represent_boolean_as_integer = true
(called from <top (required)> at /Users/nruth/dev/jsonapi-authorization/spec/dummy/app/models/article.rb:1)
```
|
Niice 👍. I just merged the other PR, and this improvement is super great as well. Thanks for doing this! |
|
Can you merge master here or rebase this on top of master? There seems to be conflicts and I'm on my mobile and fixing the conflict would be a bit difficult for me |
|
Yep will do. |
Delete the conflicting ruby-verison file - it's gitignored now so that devs can set whichever they like
|
I've merged master, the conflicts were the travis file's ruby versions and the Rails 5 isn't in the travis builds currently, but picking versions to test isn't obvious so I'm leaving that for another pr. |
|
Looks great to me! For rails versions, I think testing the latest patch release of each minor release would be a good strategy. So that would be:
If supporting 4.2 is causing trouble, we can also look into removing that from the build matrix. |
3 participants
This would update the dev and ci ruby version from an expired/EOL ruby 2.1 version to something newer. In fact, it lets people use whatever they want locally, and runs 2.3-2.5 on CI. I think this is nice because it would have meant as a new contributor I didn't need to wait to download/install ruby 2.1.2 and could have just used 2.4.3 or whichever I already had installed.
This reuses a commit from a previous pull request (nicer for the author). It looks ok to me, but I'm also going to open an alternative PR that only changes the ruby version.