Skip to content

Create Github Action for Tests #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cloke
Copy link
Collaborator

@cloke cloke commented Jan 14, 2021

This will run the tests, but the tests fail which appears to be related to cerebris/jsonapi-resources#1343. Although the reports of the errors are related to rails 6.1 this somehow is reported on these tests.

Failure/Error: require "jsonapi-resources"

NameError:
  uninitialized constant ActionController::ForceSSL

@valscion
Copy link
Member

Thanks for taking a stab at this!

Are we somehow able to use the Appraisal generated gemfiles that are here: https://github.com/venuu/jsonapi-authorization/blob/master/.travis.yml ?

I think that would make the GitHub actions work.

@valscion
Copy link
Member

Hmm, I wonder why the GitHub actions didn't start. This repo is configured like so:

Actions

Would you be able to create another pull request from a branch other than master and allow edit rights to that branch by me via the pull request edit UI? That way I could try to trigger a build by pushing a new commit

@cloke
Copy link
Collaborator Author

cloke commented Jan 15, 2021

Added this pr from a different branch #138

@cloke cloke closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants