Run CI against Rails 6 #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianswko
commented
Oct 3, 2019
.travis.yml
Outdated
| - gemfiles/rails_4_2_pundit_2.gemfile | ||
| - gemfiles/rails_5_0_pundit_2.gemfile | ||
| - gemfiles/rails_5_1_pundit_2.gemfile | ||
| - gemfiles/rails_5_2_pundit_2.gemfile | ||
| - gemfiles/rails_6_0_pundit_2.gemfile | ||
| matrix: | ||
| exclude: |
There was a problem hiding this comment.
This is the minimum number of exclusions since rails 4.2 doesn't like ruby 2.5 and rails 6 doesn't support ruby 2.3. Totally open to adding more exclusions so we're not running 16 builds
There was a problem hiding this comment.
Is it possible to only run Ruby 2.5 for Rails 6 runs, and keep 2.3 for other Rails versions?
valscion
approved these changes
Jan 12, 2020
lgebhardt
pushed a commit
to lgebhardt/jsonapi-authorization
that referenced
this pull request
Feb 8, 2020
* Run CI against Rails 6 * Use ruby 2.5 * Dummy app updates for rails 6 * Run all but Rails 4.2 tests with Ruby 2.5 * Add empty asset manifest to appease Rails Co-authored-by: Vesa Laakso <482561+valscion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosens the
sqlite3dev dependency to allow tests to run on any supported version of rails.Adds appraisals and gemfiles for rails 6 to run in CI
Updates the ruby version in CI to 2.5
Resolves #132