Only open the calendar for ArrowUp and ArrowDown (Hacker0x01#1395)

* don't open calendar upon left and right arrow key * only open calendar upon ArrowDown and ArrowUp key
ventusrisk · Jun 14, 2018 · 6cf5587 · 6cf5587
1 parent 087a7e9
commit 6cf5587
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/index.jsx b/src/index.jsx
@@ -415,7 +415,7 @@ export default class DatePicker extends React.Component {
       !this.props.inline &&
       !this.props.preventOpenOnFocus
     ) {
-      if (eventKey !== "Enter" && eventKey !== "Escape" && eventKey !== "Tab") {
+      if (eventKey === "ArrowDown" || eventKey === "ArrowUp") {
         this.onInputClick();
       }
       return;

diff --git a/test/datepicker_test.js b/test/datepicker_test.js
@@ -631,13 +631,20 @@ describe("DatePicker", () => {
       utils.formatDate(data.datePicker.state.preSelection, data.testFormat)
     ).to.equal(utils.formatDate(data.copyM, data.testFormat));
   });
-  it("should open the calendar when an arrow key is pressed", () => {
+  it("should open the calendar when the down arrow key is pressed", () => {
     var data = getOnInputKeyDownStuff();
     data.datePicker.setOpen(false);
     expect(data.datePicker.state.open).to.be.false;
-    TestUtils.Simulate.keyDown(data.nodeInput, getKey("ArrowLeft"));
+    TestUtils.Simulate.keyDown(data.nodeInput, getKey("ArrowDown"));
     expect(data.datePicker.state.open).to.be.true;
   });
+  it("should not open the calendar when the left arrow key is pressed", () => {
+    var data = getOnInputKeyDownStuff();
+    data.datePicker.setOpen(false);
+    expect(data.datePicker.state.open).to.be.false;
+    TestUtils.Simulate.keyDown(data.nodeInput, getKey("ArrowLeft"));
+    expect(data.datePicker.state.open).to.be.false;
+  });
   it("should default to the current day on Enter", () => {
     const data = getOnInputKeyDownStuff({ selected: null });
     TestUtils.Simulate.keyDown(data.nodeInput, getKey("Enter"));