forked from boltgolt/howdy
-
Notifications
You must be signed in to change notification settings - Fork 0
release: v1.1.2 - Config Restore After apt remove / Reinstall #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.1.1 | ||
| 1.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # 🚀 Ubuntu Hello v1.1.2 Release | ||
|
|
||
| Welcome to the **v1.1.2** release of **Ubuntu Hello**! This patch fixes setup-wizard and face-enrollment failures after **`apt remove` followed by `apt install`**: dpkg does not restore a deleted `config.ini` conffile, so `/etc/ubuntu-hello/config.ini` could be missing and `ubuntu-hello add` crashed with `configparser.NoSectionError: No section: 'video'`. The package now restores the default config from `/usr/share/ubuntu-hello/config.ini` on configure and at CLI/compare runtime. | ||
|
|
||
| --- | ||
|
|
||
| ## ✨ Key Enhancements in v1.1.2 | ||
|
|
||
| * **📄 Config restore after apt remove / reinstall**: | ||
| * New `config_ensure.py` copies the packaged default into `/etc/ubuntu-hello/config.ini` when the live file is missing or sectionless (never overwrites an existing config with sections). | ||
| * `debian/ubuntu-hello.postinst` restores `config.ini` from `/usr/share/ubuntu-hello/config.ini` during `configure`. | ||
| * Meson installs the default template to `/usr/share/ubuntu-hello/config.ini` (`install_data` on `config.ini`). | ||
| * `ubuntu-hello` CLI and `compare.py` call `ensure_system_config()` before reading config so `add` / `set` work even if postinst was skipped. | ||
| * **🛡️ Graceful handling when config is absent**: | ||
| * `VideoCapture` no longer raises `NoSectionError` on a missing `[video]` section — exits with code `14` (invalid device) like a bad `device_path`. | ||
| * Settings **Video** tab (`tab_video.py`) treats a missing `[video]` section as `device_path = none` instead of crashing. | ||
| * **🖥️ Desktop / greeter / wallet coverage (unchanged targets, config-restore-aware)**: | ||
| * Face auth via `common-auth` stays desktop-agnostic with **GDM, SDDM, LightDM**. | ||
| * Setup wizard and Settings work on every supported desktop after PPA reinstall: | ||
|
|
||
| | Desktop | Face auth | Theme follow | Session wallet auto-unlock | | ||
| |---------|-----------|--------------|----------------------------| | ||
| | **GNOME / Ubuntu** | Yes | Yes | GNOME Keyring (`pam_gnome_keyring`) | | ||
| | **KDE Plasma** | Yes | Yes | **KWallet** (`pam_kwallet5`) | | ||
| | **XFCE** | Yes | Yes | GNOME Keyring when present | | ||
| | **Cinnamon** | Yes | Yes | GNOME Keyring when present | | ||
| | **MATE** | Yes | Yes | GNOME Keyring when present | | ||
| | **Budgie** | Yes | Yes | GNOME Keyring when present | | ||
| | **LXQt** | Yes | Yes | GNOME Keyring when present | | ||
|
|
||
| * CI compat cells (still parallel, Ubuntu 26.04): `baseline`, `gnome`, `kde`, `xfce`, `cinnamon`, `mate`, `budgie`, `lxqt`. | ||
| * **🧪 Tests**: | ||
| * New `tests/test_config_ensure.py` (restore missing/empty config, postinst copy, Meson share template). | ||
| * `tests/test_recorders.py` covers missing `[video]` section in `VideoCapture`. | ||
| * `tests/test_paths_factory.py` covers `default_config_file_path()`. | ||
|
|
||
| --- | ||
|
|
||
| ## 📥 Installation | ||
|
|
||
| ### Method 1: Quick Install (Recommended) | ||
| Open your terminal and run the universal installer: | ||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/ventura8/ubuntu-hello/master/install.sh | sudo bash | ||
| ``` | ||
|
|
||
| ### Method 2: PPA (Ubuntu / Linux Mint) | ||
| ```bash | ||
| sudo add-apt-repository ppa:ventura8/ubuntu-hello | ||
| sudo apt update | ||
| sudo apt install ubuntu-hello | ||
| ``` | ||
|
|
||
| If you previously removed Ubuntu Hello and `/etc/ubuntu-hello/config.ini` is missing, upgrade to **v1.1.2** or restore only when the live file is absent: | ||
| ```bash | ||
| sudo test ! -e /etc/ubuntu-hello/config.ini && sudo install -D -m 644 /usr/share/ubuntu-hello/config.ini /etc/ubuntu-hello/config.ini | ||
| ``` | ||
|
|
||
| ### Method 3: Debian / Manual Package | ||
| Download the attached `.deb` package for your architecture, then install it using `apt` or `gdebi`: | ||
| ```bash | ||
| sudo apt install ./ubuntu-hello_1.1.2-1ppa1_amd64.deb | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## 📋 Changelog (v1.1.2) | ||
|
|
||
| * **Release**: Version is **`1.1.2`** / **`v1.1.2`** from the repo-root **`VERSION`** file (single source of truth); `debian/changelog` top entry added for this release. | ||
| * **Config restore**: `config_ensure.py`; postinst copy from `/usr/share/ubuntu-hello/config.ini`; Meson `install_data` for share template; CLI + compare auto-restore. | ||
| * **Robustness**: `VideoCapture` and Settings Video tab tolerate missing `[video]` section. | ||
| * **Compatibility**: Unchanged multi-DE / greeter / wallet targets (GNOME, KDE Plasma, XFCE, Cinnamon, MATE, Budgie, LXQt; GDM/SDDM/LightDM; GNOME Keyring + KWallet); CI cells `baseline` + all seven DEs. | ||
| * **Docs / agents**: `AGENTS.md`, INSTRUCTIONS, architecture README, `installer-tester` / `test-runner` skills. | ||
| * **Tests**: `test_config_ensure.py`, recorder missing-section test, paths_factory default template path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # Ubuntu Hello v1.1.2 - Config Restore After apt remove / Reinstall | ||
|
|
||
| This patch fixes setup-wizard and face-enrollment failures after **`apt remove` followed by `apt install`**. dpkg does not restore a deleted `config.ini` conffile, so `/etc/ubuntu-hello/config.ini` could be missing and `ubuntu-hello add` crashed with `configparser.NoSectionError: No section: 'video'`. The package now restores the default config from `/usr/share/ubuntu-hello/config.ini` on configure and at CLI/compare runtime. | ||
|
|
||
| --- | ||
|
|
||
| ## 📄 Config Restore | ||
|
|
||
| * New **`config_ensure.py`** copies the packaged default into `/etc/ubuntu-hello/config.ini` when the live file is missing or sectionless (never overwrites an existing config with sections). | ||
| * **`debian/ubuntu-hello.postinst`** restores `config.ini` from `/usr/share/ubuntu-hello/config.ini` during `configure`. | ||
| * Meson installs the default template to **`/usr/share/ubuntu-hello/config.ini`**. | ||
| * **`ubuntu-hello` CLI** and **`compare.py`** call `ensure_system_config()` before reading config. | ||
|
|
||
| **Manual workaround** (pre-v1.1.2, only if the live file is absent): | ||
| ```bash | ||
| sudo test ! -e /etc/ubuntu-hello/config.ini && sudo install -D -m 644 /usr/share/ubuntu-hello/config.ini /etc/ubuntu-hello/config.ini | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## 🛡️ Graceful Degradation | ||
|
|
||
| * **`VideoCapture`** no longer raises `NoSectionError` on a missing `[video]` section — exits with code `14` (invalid device). | ||
| * Settings **Video** tab treats a missing `[video]` section as `device_path = none`. | ||
|
|
||
| --- | ||
|
|
||
| ## 🖥️ Desktop, Greeter & Wallet Compatibility | ||
|
|
||
| Face authentication via PAM (`common-auth`) remains **desktop-agnostic** and works with **GDM, SDDM, LightDM**: | ||
|
|
||
| | Desktop | Face auth | Theme follow | Session wallet auto-unlock | | ||
| |---------|-----------|--------------|----------------------------| | ||
| | **GNOME / Ubuntu** | Yes | Yes | GNOME Keyring (`pam_gnome_keyring`) | | ||
| | **KDE Plasma** | Yes | Yes | **KWallet** (`pam_kwallet5`) | | ||
| | **XFCE** | Yes | Yes | GNOME Keyring when present | | ||
| | **Cinnamon** | Yes | Yes | GNOME Keyring when present | | ||
| | **MATE** | Yes | Yes | GNOME Keyring when present | | ||
| | **Budgie** | Yes | Yes | GNOME Keyring when present | | ||
| | **LXQt** | Yes | Yes | GNOME Keyring when present | | ||
|
|
||
| * **CI compat matrix** (parallel, Ubuntu 26.04): `baseline`, `gnome`, `kde`, `xfce`, `cinnamon`, `mate`, `budgie`, `lxqt`. | ||
|
|
||
| --- | ||
|
|
||
| ## 🧪 Tests | ||
|
|
||
| * `tests/test_config_ensure.py` — restore missing/empty config, postinst copy, Meson share template. | ||
| * `tests/test_recorders.py` — missing `[video]` section in `VideoCapture`. | ||
| * `tests/test_paths_factory.py` — `default_config_file_path()`. | ||
|
|
||
| --- | ||
|
|
||
| ## 📥 Installation & Upgrade | ||
|
|
||
| ### Universal Installer (Recommended) | ||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/ventura8/ubuntu-hello/master/install.sh | sudo bash | ||
| ``` | ||
|
|
||
| ### Ubuntu PPA | ||
| ```bash | ||
| sudo add-apt-repository ppa:ventura8/ubuntu-hello | ||
| sudo apt update | ||
| sudo apt install ubuntu-hello | ||
| ``` | ||
|
|
||
| **Full Changelog**: [v1.1.1...v1.1.2](https://github.com/ventura8/ubuntu-hello/compare/v1.1.1...v1.1.2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.