Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on requests-negotiate-sspi on Windows. On other platforms, depend on requests-kerberos and pykerberos. #199

Merged
merged 7 commits into from
Sep 30, 2021
Merged

Depend on requests-negotiate-sspi on Windows. On other platforms, depend on requests-kerberos and pykerberos. #199

merged 7 commits into from
Sep 30, 2021

Conversation

pdecat
Copy link
Collaborator

@pdecat pdecat commented Sep 30, 2021 •
edited
Loading

This reinstates the behavior from setup.py before migration to poetry:

if system() == 'Windows':
    install_requires.append('requests-negotiate-sspi>=0.3.4')
else:
    install_requires.append('requests_kerberos')

https://github.com/venth/aws-adfs/pull/144/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R29-R32

@pdecat pdecat changed the title Depend on requests-negotiate-sspi on Windows. On other platform, depend on requests-kerberos and pykerberos. Depend on requests-negotiate-sspi on Windows. On other platforms, depend on requests-kerberos and pykerberos. Sep 30, 2021
@pdecat pdecat mentioned this pull request Sep 30, 2021
Open
@pdecat pdecat merged commit fceb8ea into master Sep 30, 2021
@pdecat pdecat deleted the fix_windows_deps branch September 30, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pdecat