-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.9-dev support #165
Conversation
Travis CI job: https://travis-ci.org/github/venth/aws-adfs/builds/703765067 Like I said in #164 (review), I'm not sure why the Travis build results do not show up in PRs. Probably some settings to adjust. Alternatively, we switch to Github Actions to get a more streamlined experience. |
Some tests are failing with python 3.9-dev: https://travis-ci.org/github/venth/aws-adfs/jobs/703765074
The underlying error is the same for all three failing tests:
|
From https://docs.python.org/3.9/whatsnew/3.9.html#removed:
Note: simply replacing |
Hi @venth, sorry this wasn't ready to merge as I did not yet fix the code compatibility for python 3.9-dev while maintaining backward compatibility with 2.7 and 3.1. |
I’ll revert the commit then
… Wiadomość napisana przez Patrick Decat ***@***.***> w dniu 03.07.2020, o godz. 15:00:
Hi @venth, sorry this wasn't ready to merge as I did not yet fix the code compatibility for python 3.9-dev while maintaining backward compatibility with 2.7 and 3.1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Commit reverted. Sorry, I was too hasty :) |
Replace python version 3.8-dev by 3.8 and add 3.9-dev.
We may want to drop 3.4 and maybe even 2.7 at some point, but there's no real gain right now. Maybe later if a cleanup or refactoring is considered at some point.
See https://devguide.python.org/#status-of-python-branches for officially supported python branches.