Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback on prompt if env, stdin or auth file do not provide both username and password #115

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

pdecat
Copy link
Collaborator

@pdecat pdecat commented Jan 22, 2019

This PR allows to only pass the username in any of the supported configuration method.

For example, when using the environment variables method but only with username defined, it will prompt for the missing password:

# alias my-aws-adfs='username=patrick@mydomain.org aws-adfs login  --env --profile=myprofile --region=eu-west-1 --adfs-host=sso.mydomain.org --ssl-verification'
# my-aws-adfs
Failed to read password from env
Password: *****
Sending request for authentication
Waiting for additional authentication
Going for aws roles

        Prepared ADFS configuration as follows:
            * AWS CLI profile                   : 'myprofile'
            * AWS region                        : 'eu-west-1'
            * Output format                     : 'json'
            * SSL verification of ADFS Server   : 'ENABLED'
            * Selected role_arn                 : 'arn:aws:iam::0123456789:role/myrole'
            * ADFS Server                       : 'sso.mydomain.org'
            * ADFS Session Duration in seconds  : '28800'
            * Provider ID                       : 'urn:amazon:webservices'
            * S3 Signature Version              : 'None'
            * STS Session Duration in seconds   : '14400'

@venth venth merged commit e594aac into venth:master Jan 23, 2019
@venth
Copy link
Owner

venth commented Jan 23, 2019

Thanks you. Released with version 1.12.3

@pdecat pdecat deleted the fallback_on_prompt branch January 23, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants