Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the XPath expression to work with the latest version of AWS… #107

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

jan-molak
Copy link
Contributor

Trying to log in with the latest version of aws-adfs results in the below error:

aws-adfs login --adfs-host auth.mycorp.com

[authenticator authenticator.py:authenticate][...-MainProcess][...-MainThread] - ERROR: Cannot extract saml assertion. Re-authentication needed?
Username: MYDOMAIN\myusername
Password:
[authenticator authenticator.py:authenticate][...-MainProcess][...-MainThread] - ERROR: Cannot extract saml assertion. Re-authentication needed?
This account does not have access to any roles.

It seems like the root cause of this problem is a change in the structure of https://signin.aws.amazon.com/saml, and the fact that the SAML form is now called saml_form rather than hiddenform:
screen shot 2018-09-19 at 10 39 04

This PR relaxes the XPath expression responsible for extracting the SAMLResponse from the website to make it work with both versions of the form.

@venth venth merged commit f3801fa into venth:master Sep 19, 2018
@venth
Copy link
Owner

venth commented Sep 19, 2018

Released with version: 1.12.2.

Thank you 👍

@jan-molak
Copy link
Contributor Author

Brilliant, thanks so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants