Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list output is too simple #20

Closed
ozbillwang opened this issue Feb 28, 2017 · 7 comments
Closed

list output is too simple #20

ozbillwang opened this issue Feb 28, 2017 · 7 comments

Comments

@ozbillwang
Copy link

ozbillwang commented Feb 28, 2017

Currently the list output is too simple, I use it to set a default profile, but sometime I need switch to other account, which it doesn't make sense for me, if always list as default.

can we have output with additional information, such as profile name, aws account alias and adfs_config.role_arn?

@venth
Copy link
Owner

venth commented Feb 28, 2017

Would you like to paste a mockup (could be formatted text), so it would be easier for me to see the results of the change?

@ozbillwang
Copy link
Author

ozbillwang commented Feb 28, 2017

change from:

$ aws-adfs list
Available profiles:
    * default

to something like this, so I can easily know what's the current default profile.

$ aws-adfs list
Available profiles:
    * default | adfs-xxx-nonprod | arn:aws:iam::xxxxxxxx:role/administrator

If getting aws account alias is not possible, because you need assume role to get the account detail, the role_arn will be useful, which can get directly from ~/.aws/config

ozbillwang pushed a commit to BWITS/aws-adfs that referenced this issue Feb 28, 2017
@ozbillwang
Copy link
Author

pull request has been raised.

ozbillwang pushed a commit to BWITS/aws-adfs that referenced this issue Mar 1, 2017
ozbillwang pushed a commit to BWITS/aws-adfs that referenced this issue Mar 1, 2017
@ozbillwang
Copy link
Author

PR has been merged.

@venth
Copy link
Owner

venth commented Mar 1, 2017

Released with version 0.2.2

@ozbillwang
Copy link
Author

@venth

Saw the codes you updated in aws_adfs/list_profiles.py, seems line 19 is not required any more.

https://github.com/venth/aws-adfs/blob/master/aws_adfs/list_profiles.py#L19

@venth
Copy link
Owner

venth commented Mar 1, 2017

You're right 😄I'll fix it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants