Skip to content

Replace print() + abort() with fatalError() so Quick Testing Framework correctly handles error #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliperkins merged 1 commit into from
Oct 27, 2016
Merged

Replace print() + abort() with fatalError() so Quick Testing Framework correctly handles error #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions DVR/SessionDataTask.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,27 +52,23 @@ class SessionDataTask: NSURLSessionDataTask {
}

if cassette != nil {
print("[DVR] Invalid request. The request was not found in the cassette.")
abort()
fatalError("[DVR] Invalid request. The request was not found in the cassette.")
}

// Cassette is missing. Record.
if session.recordingEnabled == false {
print("[DVR] Recording is disabled.")
abort()
fatalError("[DVR] Recording is disabled.")
}

let task = session.backingSession.dataTaskWithRequest(request) { [weak self] data, response, error in

//Ensure we have a response
guard let response = response else {
print("[DVR] Failed to record because the task returned a nil response.")
abort()
fatalError("[DVR] Failed to record because the task returned a nil response.")
}

guard let this = self else {
print("[DVR] Something has gone horribly wrong.")
abort()
fatalError("[DVR] Something has gone horribly wrong.")
}

// Still call the completion block so the user can chain requests while recording.
Expand Down