fix: emit event for plugin register

venkatperi · Aug 17, 2017 · 977f30a · 977f30a
1 parent aa733b8
commit 977f30a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/lib/js_dsl.js b/lib/js_dsl.js
@@ -1,3 +1,4 @@
+/* eslint-disable class-methods-use-this */
 // Copyright 2017, Venkat Peri.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a
@@ -28,14 +29,21 @@ const debug = require( 'debug' )( 'js_dsl' );
  * JavaScript DSLs.
  */
 class JsDsl extends EventEmitter {
-  constructor( parentBuilder ) {
+  constructor( name, parentBuilder ) {
     super();
+    if ( typeof name !== 'string' ) {
+      // eslint-disable-next-line no-param-reassign
+      [name, parentBuilder] = [null, name];
+    }
+    this._name = name;
     this._parentBuilder = parentBuilder;
     this.__contextStack = [];
     this._globalsStack = {};
     this._factories = {};
     this._propertyNames = [];
     this._methodNames = [];
+    this.on( 'register', this.register.bind( this ) );
+    this.emit( 'register', this );
   }
 
   get _child() {
@@ -61,6 +69,10 @@ class JsDsl extends EventEmitter {
     return this._context._parent;
   }
 
+  get name() {
+    return this._name;
+  }
+
   get propertyNames() {
     return this._propertyNames;
   }
@@ -292,6 +304,9 @@ class JsDsl extends EventEmitter {
     }
   }
 
+  register() {
+  }
+
   /**
    *  Register a factory for a node name
    *

diff --git a/test/builder.js b/test/builder.js
@@ -48,8 +48,7 @@ class TipFactory extends AbstractFactory {
 }
 
 class TreeBuilder extends JsDsl {
-  constructor() {
-    super();
+  register() {
     this.registerFactory( 'tree', new TreeFactory() );
     this.registerFactory( 'tip', new TipFactory() );
     this.registerPropertyNames( ['name', 'description'] );