Potential fix for code scanning alert no. 14: Clear-text logging of sensitive information #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -79,7 +79,8 @@ | |||
| except Exception as e: | |||
| sanitized_params = sanitize_sensitive_info(params) | |||
| sanitized_params = sanitize_sensitive_info(params) | |||
| logger.error(f"Tidb database,\nsql:{sql},\nparams:{sanitized_params},\nerror:{sanitize_sensitive_info({'error': str(e)})}") | |||
| sanitized_error = sanitize_sensitive_info({'error': str(e)}) | |||
| logger.error(f"Tidb database,\nsql:{sql},\nparams:{sanitized_params},\nerror:{sanitized_error}") | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/venkateshpabbati/LightRAG/security/code-scanning/14
To fix the problem, we need to ensure that all sensitive information is properly sanitized before being logged. This involves using the
sanitize_sensitive_infofunction consistently and correctly to mask sensitive data. Specifically, we need to ensure that theparamsdictionary and any other potentially sensitive information are sanitized before being included in log messages.sanitize_sensitive_infofunction is used to sanitize theparamsdictionary and any other sensitive data before logging.Suggested fixes powered by Copilot Autofix. Review carefully before merging.