Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Introduce MultiChannelStockLocationStrategy #3243

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

michaelbromley
Copy link
Member

Description

Addresses #2356.

Breaking changes

This PR replaces the default stockLocationStrategy with a brand new one. Although technically it means that the default behaviour is different in multi-channel, multi-location setups, this is only because the old default behaviour was very much non-functional in that scenario.

All the e2e tests pass, so for the single-location scenario supported by the old default, this new one behaves identically.

Therefore in the release notes we will just include a note about this, and provide instructions on how to get the old behaviour back in the unlikely event that someone knowingly relied upon it.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Fixes #2356. This commit introduces a much more sophisticated stock location strategy
that takes into account the active channel, as well as available stock levels
in each available StockLocation.

With v3.1.0 it will become the default strategy.
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 29, 2024 0:13am

@michaelbromley michaelbromley changed the base branch from master to minor November 28, 2024 16:34
@michaelbromley michaelbromley merged commit 563f49e into minor Nov 29, 2024
32 checks passed
@michaelbromley michaelbromley deleted the issue-2356 branch November 29, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant