Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments-plugin): Allow use of Stripe-Account header #3194

Merged

Conversation

shingoaoyama1
Copy link
Contributor

Description

This pull request allow the application to send the Stripe-Account header that is used to create a direct charge with Stripe Connect #3183
https://docs.stripe.com/connect/authentication#stripe-account-header

Breaking changes

I am not able to determine a breaking change. The implemented features represent new functionality and should have no effect on existing implementations.

Screenshots

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 6, 2024 11:45am

Copy link

sonarqubecloud bot commented Nov 6, 2024

@michaelbromley michaelbromley merged commit 3f66216 into vendure-ecommerce:minor Nov 15, 2024
29 of 30 checks passed
@michaelbromley
Copy link
Member

Beautiful PR: clean, well-documented, perfectly follows existing conventions, tested. 10/10 🙌

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants