chore(elasticsearch plugin) updating es to v8.13.1 #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dlhck
changed the title
michaelbromley
requested changes
Nov 15, 2024
| @@ -166,6 +167,13 @@ export class DefaultSearchPlugin implements OnApplicationBootstrap, OnApplicatio | |||
| } | |||
| }); | |||
|
|
|||
| this.eventBus.ofType(StockMovementEvent).subscribe(event => { | |||
There was a problem hiding this comment.
This is from the other PR that got merged right? Let's clean that up to only include the actual change relating to ES version.
| container_name: elasticsearch | ||
| environment: | ||
| - node.name=es |
There was a problem hiding this comment.
If you pull latest changes from the master branch you should see that all the docker compose configs are now in a root-level compose file. Can you move these changes to there?
| port: 9200, | ||
| }), | ||
| ], | ||
| // Add an instance of the plugin to the plugins array |
There was a problem hiding this comment.
These docs are generated, so you should not edit them directly. Instead, you need to edit the doc block of the plugin source and add the changes there. Next time the docs are generated, these changes will be added to the md files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue.
Breaking changes
Does this PR include any breaking changes we should be aware of?
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: