feat(payments-plugin): Dont handle mollie webhook for any state after PaymentSettled #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
michaelbromley
merged commit 754da02
into
vendure-ecommerce:master
16 of 18 checks passed
|
Thanks Martijn! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally, we receive webhooks from Mollie, while the Vendure order is already in state Shipped or Delivered. This results in a
ORDER_PAYMENT_STATE_ERROR, because the order is already past its payment states. Even worse, a 500 is returned to Mollie, so Mollie will keep retrying this webhook.While the root cause of these incoming hooks is not known, we should still not handle Mollie hooks when an order is already in PaymentSettled, Shipped or Delivered.
Checklist
📌 Always:
👍 Most of the time: