Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-devkit): Add call to exit in sigint handler #2558

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(ui-devkit): Add call to exit in sigint handler #2558

merged 1 commit into from
Dec 1, 2023

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Nov 30, 2023

Description

Required exit because the default node handler is removed, and when developing a vendure app it never exits when using ctrl+c

Breaking changes

No

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

⚡ Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@mcfedr
fix(ui-devkit): Add call to exit in sigint handler
c827e48 
Required exit because the default node handler is removed
@michaelbromley michaelbromley merged commit bfd9281 into vendure-ecommerce:minor Dec 1, 2023
12 checks passed
@michaelbromley
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcfedr @michaelbromley