Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promotion needs a description #1990

Closed
michaelbromley opened this issue Jan 17, 2023 · 1 comment
Closed

Promotion needs a description #1990

michaelbromley opened this issue Jan 17, 2023 · 1 comment
Milestone
v2.0

Comments

@michaelbromley
Copy link
Member

Is your feature request related to a problem? Please describe.
The Promotion entity only has a name. It should also have a description field for extended details about the promotion.

Describe the solution you'd like
Add a description text field
@michaelbromley michaelbromley added this to the v2.0 milestone Jan 17, 2023
@michaelbromley michaelbromley moved this to 📅 Planned in Vendure OS Roadmap Jan 17, 2023
@michaelbromley michaelbromley moved this from 📅 Planned to 🏗 In progress in Vendure OS Roadmap Feb 24, 2023
@michaelbromley
Copy link
Member Author

At the same time I'm also making Promotion a translatable entity, so name and description can be localized.

michaelbromley added a commit that referenced this issue Feb 24, 2023
@michaelbromley
feat(core): Make Promotion entity translatable, add description
dada243 
Relates to #1990

BREAKING CHANGE: The Promotion entity is now translatable, which means existing promotions will need
to be migrated to the new DB schema and care taken to preserve the name data. Also the GraphQL
API for creating and updating Promotions, as well as the corresponding PromotionService methods
have changed to take a `translations` array for setting the `name` and `description` in a given
language.
michaelbromley added a commit that referenced this issue Feb 24, 2023
@michaelbromley
feat(admin-ui): Add support for translatable Promotions
00bd433 
Relates to #1990
@michaelbromley michaelbromley moved this from 🏗 In progress to 🔖 Ready in Vendure OS Roadmap Apr 12, 2023
@michaelbromley michaelbromley moved this from 🔖 Ready to ✅ Done in Vendure OS Roadmap Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Vendure OS Roadmap
Archived in project
Milestone
v2.0
Development

No branches or pull requests
1 participant
@michaelbromley