fix(admin-ui): Make sku optional in create-product-variant-dialog (#3007

) Closes #2999
vendure-ecommerce · Aug 11, 2024 · 13fe069 · 13fe069
1 parent 1538a05
commit 13fe069
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...g/src/components/create-product-variant-dialog/create-product-variant-dialog.component.ts b/...g/src/components/create-product-variant-dialog/create-product-variant-dialog.component.ts
@@ -1,13 +1,12 @@
 import { ChangeDetectionStrategy, Component, OnInit } from '@angular/core';
-import { FormBuilder, FormControl, FormGroup, FormRecord, Validators } from '@angular/forms';
+import { FormBuilder, FormControl, FormRecord, Validators } from '@angular/forms';
 import {
     CreateProductVariantInput,
     CurrencyCode,
     Dialog,
     GetProductVariantOptionsQuery,
 } from '@vendure/admin-ui/core';
 import { notNullOrUndefined } from '@vendure/common/lib/shared-utils';
-import { combineLatest } from 'rxjs';
 
 @Component({
     selector: 'vdr-create-product-variant-dialog',
@@ -20,7 +19,7 @@ export class CreateProductVariantDialogComponent implements Dialog<CreateProduct
     product: NonNullable<GetProductVariantOptionsQuery['product']>;
     form = this.formBuilder.group({
         name: ['', Validators.required],
-        sku: ['', Validators.required],
+        sku: [''],
         price: [''],
         options: this.formBuilder.record<string>({}),
     });
@@ -67,14 +66,14 @@ export class CreateProductVariantDialogComponent implements Dialog<CreateProduct
 
     confirm() {
         const { name, sku, options, price } = this.form.value;
-        if (!name || !sku || !options || price == null) {
+        if (!name || !options || price == null) {
             return;
         }
 
         const optionIds = Object.values(options).filter(notNullOrUndefined);
         this.resolveWith({
             productId: this.product.id,
-            sku,
+            sku: sku || '',
             price: Number(price),
             optionIds,
             translations: [