Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKU field should be optional when create new product variant inside Manage variants #2999

Closed
Dominic-Preap opened this issue Aug 8, 2024 · 0 comments
Labels
contributions welcome P4: low Non-critical, workarounds exist type: bug 🐛 Something isn't working @vendure/admin-ui

Comments

@Dominic-Preap
Copy link
Contributor

Describe the bug

In product detail, when we try to add new option values and create new product variant, the SKU field is required. This should not be like that as when create new product the first time or when update product variants, the SKU can be optional.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to Product detail
  2. Go to Manage variants
  3. Click Create product variant
  4. Fill info except SKU but it's required

Expected behavior

SKU should be optional just like when create new product with Product variants.

Environment (please complete the following information):

  • @vendure/core version: 3.0.0
  • Nodejs 20
  • Database: mysql

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome P4: low Non-critical, workarounds exist type: bug 🐛 Something isn't working @vendure/admin-ui
Projects
None yet
Development

No branches or pull requests

2 participants