-
Notifications
You must be signed in to change notification settings - Fork 0
[VDP-36906] Remove internal API use cases #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes internal API usage from the VenaETL class to comply with VDP-36906, eliminating functions that relied on non-public endpoints and updating the package version.
- Removed internal API methods (
models(),get_models(),processes(),get_processes(),job_history()) - Updated package version from 0.1.2 to 0.1.3
- Added GitHub PR template and CODEOWNERS file for better project governance
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vepi/vena_etl.py | Removed internal API URLs and methods, updated default page size parameter |
| vepi/init.py | Bumped version to 0.1.3 |
| README.md | Removed documentation for deleted internal API methods |
| .github/PULL_REQUEST_TEMPLATE.md | Added PR template for standardized submissions |
| .github/CODEOWNERS.txt | Added code ownership assignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
|
||
| # API URLs | ||
| self.base_url = f'https://{hub}.vena.io/api/public/v1' | ||
| self.closed_url = f'https://{hub}.vena.io/api/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was reading through the entire file. Maybe you and I can go over it and put comments on it for future changes. For example, the hubs constructor argument could be a enum rather than a string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll make a separate PR for general clean-up stuff
MxSahil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#VDP-36906
Other
https://venasolutions.atlassian.net/browse/VDP-36906
Code change / Fix