Skip to content

Conversation

@GregHetherington
Copy link
Contributor

#VDP-36906

Other

https://venasolutions.atlassian.net/browse/VDP-36906

Code change / Fix

  • Removed functions that used Internal API
  • Added PR template

@snyk-io
Copy link

snyk-io bot commented Aug 14, 2025

🎉 Snyk checks have passed. No issues have been found so far.

code/snyk check is complete. No issues have been found. (View Details)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes internal API usage from the VenaETL class to comply with VDP-36906, eliminating functions that relied on non-public endpoints and updating the package version.

  • Removed internal API methods (models(), get_models(), processes(), get_processes(), job_history())
  • Updated package version from 0.1.2 to 0.1.3
  • Added GitHub PR template and CODEOWNERS file for better project governance

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vepi/vena_etl.py Removed internal API URLs and methods, updated default page size parameter
vepi/init.py Bumped version to 0.1.3
README.md Removed documentation for deleted internal API methods
.github/PULL_REQUEST_TEMPLATE.md Added PR template for standardized submissions
.github/CODEOWNERS.txt Added code ownership assignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

# API URLs
self.base_url = f'https://{hub}.vena.io/api/public/v1'
self.closed_url = f'https://{hub}.vena.io/api/'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was reading through the entire file. Maybe you and I can go over it and put comments on it for future changes. For example, the hubs constructor argument could be a enum rather than a string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll make a separate PR for general clean-up stuff

Copy link

@MxSahil MxSahil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GregHetherington GregHetherington merged commit ecbb23c into main Aug 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants