Remove wrongly used browser field from pkg.json #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a common misconception but browser field should not be used for UMD bundles. It's an alias field that should contain alternative implementations browser-specific implementations.
To put more context around it - you want modern bundlers (such as webpack) to pick up contents of module field because it refers to file authored in ES modules and thus supporting tree-shaking etc. But by specifying a browser field you make it more important for a bundler like webpack and it picks it up instead of the module one. So many consumers of your library end up with unoptimized bundle & extra bytes if they use ur dependencies somewhere else too (because UMD bundle contains copy of them).
If you have any questions regarding this, please just ask - I'm happy to help and to clarify this more if needed :)