Conversation
will abstract code in next commit
reverting changes
.swiftpm/xcode/xcshareddata/
Package.resolved project.xproj got rid of poor spacing
easier to control navigation if through the app instead
…emoved from FlowStack
zac
approved these changes
Mar 31, 2025
Member
zac
left a comment
zac
left a comment
There was a problem hiding this comment.
Looks good, we can possibly leave the 0.x fractional math for a future improvement if things seem good.
Sources/FlowStack/FlowStack.swift
Outdated
| init() { | ||
| cancellable = NotificationCenter.default | ||
| .publisher(for: UIAccessibility.voiceOverStatusDidChangeNotification) | ||
| .sink { [weak self] _ in |
Member
There was a problem hiding this comment.
☝️ I think you can use .assign() here instead of needing a cancellable.
Sources/FlowStack/FlowStack.swift
Outdated
| return destination | ||
| } | ||
|
|
||
| private func SkrimZIndex() -> Double { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inclues:
Handling skrim
FlowLink being visible in dismissal animation
Demo of regular FlowStack + fixes:
Flowstack.Final.mp4